QR code component

Community feedback

• 

  David Oncu•350

  @david-oncuPosted over 2 years ago

  Congratulations Magda on your solutions!

  Few suggestions on accessibility issues:

  All page content should be contained by landmarks

  Context:

  <div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://github.com/magda-korzeniowska">Magda Korzeniowska</a>. </div>

  • change the "div" to the "footer":

  <footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://github.com/magda-korzeniowska">Magda Korzeniowska</a>. </footer>

  ---

  All page content should be contained by landmarks

  Context:

  <article class="card">

  • change the "article" to "main".

  Overall great solutions.

  Marked as helpful

  0

  ---

  

  Magda Korzeniowska•80

  @magda-korzeniowskaPosted over 2 years ago

  @david-oncu Thank you for the feedback!

  1