hamza• 390
@Hamzaouladev
Posted
hello @victoriamnx, great job finishing this project, i have some feedback i hope you find interesting:
- it's better to let the container determine the width of your component, not the content, and vise versa when it comes to height.. so i suggest you remove the width from your image element and add it to your container element, the way i suggest you do it is to give it a relative
width
and a fixedmax-width
for responsiveness just like this:
.box {
width: 90%;
max-width: 22.5rem;
}
- also a good hack when starting projects is to add the following code to your images tags to prevent unwanted behavior:
img,
picture {
max-width: 100%;
display: block;
}
i hope you found my feedback helpful, keep going!
Marked as helpful
0