Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

@victoriamnx

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This project was a little bit easy to do but i had some problems to do the box, happily i learn how to do and the result came out.

Community feedback

hamza 390

@Hamzaouladev

Posted

hello @victoriamnx, great job finishing this project, i have some feedback i hope you find interesting:

  • it's better to let the container determine the width of your component, not the content, and vise versa when it comes to height.. so i suggest you remove the width from your image element and add it to your container element, the way i suggest you do it is to give it a relative width and a fixed max-width for responsiveness just like this:
.box {
   width: 90%;
   max-width: 22.5rem;
}
  • also a good hack when starting projects is to add the following code to your images tags to prevent unwanted behavior:
img,
picture {
  max-width: 100%;
  display: block;
}

i hope you found my feedback helpful, keep going!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord