Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

css

Erenโ€ข 210

@for-dev9

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


How to fix warning "Page should contain a level-one heading" ?

Community feedback

@MelvinAguilar

Posted

Hi @for-dev9 ๐Ÿ‘‹, good job completing this challenge, and welcome to the Frontend Mentor Community! ๐ŸŽ‰

Regarding your question:

  • Even though this challenge is not a full page, you should use semantic tags and a title tag <h1> (level-one heading) in your solution. Inside your 'main' element, you can create an '<h1>' that will not be visible visually but is visible to screen-readers. To hide content visually, you can use the sr-only class. You can copy the styles of this class here.
<h1 class="sr-only">QR Card Component</h1>

The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page.

  • The <p> with text "Improve your front-end skills by building projects" , is considered a heading element, change it to an <h2>.

Good job, and happy coding! ๐Ÿ˜

Marked as helpful

1

Erenโ€ข 210

@for-dev9

Posted

@MelvinAguilar Thanks for your guide. Warning is gone after add <h1> tag.

0

@davdifr

Posted

Hey, first of all, great job! Your work is very similar to the original!

I have two tips for you:

  1. For the border-radius of the card, use a pixel size, in this case 10 should be enough. As you can see from your result, the edges have a "strange" shape because you used a % size that is usually used to obtain a circle if you have a div with equal height and width.
  2. As you can see from the preview image, there is a slight shadow behind the card, it should not be difficult with your skills to add it without problems!

That said, once again great job and good coding!

Marked as helpful

1

Erenโ€ข 210

@for-dev9

Posted

@davdifr thank you for your advice, i forgot to add shadow :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord