@correlucas
Posted
👾Hi Marco Louis, congrats on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
The image is not responsive yet, a quick way to make any image responsive and respecting the container size is to add display: block
and max-width: 100%
to the <img>
selector. To improve the responsiveness even more adding the auto-crop property you can add object-fit: cover
to make the image crop inside the container its inside.
img {
display: block;
object-fit: cover;
max-width: 100%;
}
The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>
. For this solution you wrap everything inside a single block of content using <div>
or <main>
(better option for accessibility) and put inside the whole content <img>
/ <h1>
and <p>
.
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
✌️ I hope this helps you and happy coding!