Design comparison
Community feedback
- @JosephArifinPosted 3 months ago
Hello! Good job on completing the challenge!
The only difference I see between yours and the design is the text below the card and the card being slightly higher which I assume you did on purpose which is fine. The only thing I can comment on is the internal css. It is generally good practice to have a external stylesheet, but your internal css is a perfectly valid solution!
Great job once again!
Marked as helpful1 - P@Islandstone89Posted 3 months ago
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a<main>. -
The alt text should be written naturally, without using
-between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website." -
I would change the heading to a
<h2>- a page should only have one<h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components. -
Change
.attributionto a<footer>, and use<p>for the text inside.
CSS:
-
It is best practice to write CSS in a separate file, often called
style.css. Create one in the same folder as theindex.html, and link to it in the<head>:<link rel="stylesheet" href="style.css">. -
Make a habit of including a proper CSS Reset at the top of the stylesheet.
-
I recommend adding a bit of
padding, for example16px, on thebody, to ensure the card doesn't touch the edges on small screens. -
Move
font-familyto thebody. -
On the
body, you have writtenheight: 100vhtwice. Remove both, and replace them withmin-height: 100svh- this way, the content will not get cut off if it grows beneath the viewport. -
Remove the margin on the card - it is not necessary, since the card is already centered using Flexbox.
-
Remove all widths in
px. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size. -
We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a
max-widthof around20rem. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Since all of the text should be centered, you only need to set
text-align: centeron the body, and remove it elsewhere. The children will inherit the value. -
Paragraphs have a default value of
font-weight: 400, so there is no need to declare it. -
On the image, add
display: block,height: autoand changewidth: 90%tomax-width: 100%- the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container.max-width: 100%makes the image shrink to fit inside its container. Also, it's usually not recommended to use negative margins, and this image doesn't need any margin, so removemargin-top. -
To create the space between the image and the edge of the card, set
paddingon all 4 sides of the card:padding: 16px;.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord