QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

    screenshot-imgur (landscape mode)📸

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Super Oleksandr•320

  @super-simonPosted almost 2 years ago

  @MelvinAguilar Thanks a lot for useful tips!

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  To center .card on the page using flexbox, replace the height in the body with min-height: 100vh.

  There is no need for <div class="card__qr-container"> <div class="card__qr-top-oval"></div>

  <div class="card__qr-bottom-oval"></div> and their styling in the css.

  There is no need to style .image-container. Give img a max-width of 100% instead of a width and height values for a responsive content and a border-radius value.

  For a responsive content replace the width in .card with max-width and give a padding value for all the sides and there is no need for a height value. max-width:320px padding:16px.

  Give h1 and p the same font-size of 15pxand the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Super Oleksandr•320

  @super-simonPosted almost 2 years ago

  @Hassiai Hello! I'll change the body's height to min-height.

  I'll leave the styling of the blue background and circles, because i'm sure that in 99% of cases backend will render the QR code without styling, just black and white squares.

  I did it as not responsive card. Sorry, now i realized that I should have mentioned it in description.

  In any case, thank you very much for such a detailed review. I will need advice on adaptability in the following tasks.

  0