Simple solution for QR component using basic BEM

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Give .qr a padding value for all the sides, there is no need to style .qr--code. Giver img a max-width of 100% instead of a height value. give .qr--information a padding value for all the side and give h1 a margin bottom value or p a margin top value.

  .qr{padding: 1rem;} 
  img{max-width:100%}
  .qr--ingromation{ padding: 1rem:}
  p{margin-top: 1rem;}
  

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Oscar Miras•160

  @omirasPosted almost 2 years ago

  @Hassiai I implemented your suggestions: I find it's cleaner and easier code than mine.

  To be honest I was not completely ok using height for the image. Thank you very much for your comment!

  1