1st attempt of QR code component

Community feedback

• 

  Carolina Herrera•70

  @CaroHerrera6Posted almost 2 years ago

  I think you can easly improve your challenge checking on the "styles-guide" sheet where you can find the right background color, font size and font family. It will definitely look much similar to the example. Also, you could put the attribution in a <footer> at the end of your code, outside the card section to make it cleaner.

  Hope this helps!

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  <div class="attribution"> should be out of <div class="container">. Replace <div class="container"> with the main tag, <div class="attribution"> with the footer tag and add the alt attribute `alt=" "` to the img tag to fix the error and accessibility issues. The value for the alt is the description of the image.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  The body has a wrong background-color. there is no need to give the body a width value. To center .container on the page using flexbox, replace the height with min-height:100vh.

  For a responsive content, replace the width of .container with max-width and remove the height value. Give the img a max-width of 100% instead of a width and height value.

  Give .header a padding value for all the sides, a text-align: center and font-size of 15px. There is no need to give p and h1 a font-size value. Give p a margin-top value and opacity:0.5 for the faded color.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  davidmurage•320

  @davidmuragePosted almost 2 years ago

  @Hassiai thankyou .

  1