Design comparison
SolutionDesign
Community feedback
- @Binh2Posted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code.
Congrats on completing your challenge! 🙌
I have 3 suggestions for you:
- Add a better alt attribute to your <img> tag <img alt="QR code to Frontend Mentor" />.
- Add box-shadow to your card
.card { box-shadow: 0.5em 0.5em 1em var(--clr-grayish-blue); }
. You could choose a different color box-shadow if you want. - You use a <h1> tag and make it inclusively hidden, but you already use the
<title>Frontend Mentor | QR code component</title>
so you don't need <h1> tag :v. Cool trick though.
If you have any questions or need further clarification, feel free to reach out to me.
You've done so well. I can't find many errors.
Happy Coding! <3 😊
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord