QR code component

Community feedback

• 

  Abubakar Ummar•220

  @HaywayaheadshotPosted almost 2 years ago

  Hi Denis

  Nice work on the project.

  I do have one recommendation.

  It is very important for the body of the HTML file to have a main tag. Attached below is a link to help you understand this concept more.

  Details about HTML semantics

  Also, the README.MD file is supposed to contain details unique to your project. What you have there is the default template. If you go through it carefully, you'll realize that it only serves as a guide on how to detail your project. Please check that and also work on it.

  Happy Coding and have a happy new year.

  Marked as helpful

  1

  ---

  

  Denis Kyznetsov•200

  @DenKuznetsPosted almost 2 years ago

  @Haywayaheadshot hello and thank you for the feedback! I will look into that. Happy new year you too :)

  0

  

  Denis Kyznetsov•200

  @DenKuznetsPosted almost 2 years ago

  @Haywayaheadshot the mdn description says that "The content of a <main> element should be unique to the document ", but in these small newbie challenges we are working mainly on individual page components, is it really necessary to include main in all of these projects?

  0

  

  Abubakar Ummar•220

  @HaywayaheadshotPosted almost 2 years ago

  @DenKuznets That is a nice question. And the answer is yes. It is important no matter how small the challenge is. The main advantage is that it help machines identify the beginning of the main content. This is handy when using search engines or screen readers for the blind and vision-impaired.

  I hope my answer helped. If you are still not convinced, please check out this article on web accessibility.

  Please let me know if you have more questions.

  Marked as helpful

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! In addition to the other suggestions I have some feedback for you if you want to improve your code.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

  If you want to learn more about the alt attribute, you can read this article.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here. You can read more about centering in CSS here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  0