@Hassiai
Posted
Replace < div class="container"> with the main tag and<h2> with <h1> to fix the accessibility issues.
To center a content on a page, add min-height:100vh; to .container and remove the height value
give #qr-code width:100% or max-width:100% instead of giving it a specific width and height values.
Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful Happy Coding
Marked as helpful
@Atharane
Posted
@Hassiai thanks for the suggestions I'll surely incorporate those changes 😃
@Atharane
Posted
@Hassiai Does this look good now? https://github.com/Atharane/qr-code-component.io
@Hassiai
Posted
@Atharane , replace <div class="attribution"> with the footer tag , sorry I forgot to mention this. everything is good. Well done and congrats
Marked as helpful
