QR Code Component HTML/CSS - Flexbox

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey! It is ok using <section> without a class in small projects but when using more than one section you need to use classes.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  Hope this is useful to you... Keep coding👍

  Marked as helpful

  0
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Lubo. Congrats on completing this challenge, it's pretty solid! I think it's okay to style using tags in relatively small projects because sometimes it's cumbersome to come up with classnames . But you might not want to do that in bigger projects😅 You might also want to wrap your div with the class "attribution" in the main landmark to resolve your accessibility issues! Happy coding and keep on coding!

  1
• 

  Luboš Bräth•650

  @Bredis79Posted over 2 years ago

  Great...thank you guys.

  0