QR code component-HTML&CSS

Community feedback

• 

  P

  Øystein Håberg•11,010

  @Islandstone89Posted 6 days ago

  HTML:

  • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Change .attribution to a <footer>, and use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Remove all styles on main.

  • Remove the margin on the card.

  • To center the card horizontally and vertically, with some space between the main and the footer, I would use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  gap: 20px;
  

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Remove the margin on the paragraph.

  • The paragraph text has poor contrast, making the text harder to read. Inspecting it in DevTools (open it using the F12 key, then inspect an element using Ctrl+Shift+I) reveals a contrast ratio of 3.53. To fullfill the Web Content Accessibility Guidelines requirements, text must have a contrast ratio of at least 4.5. Since the color is in hsl(hue, saturation, lightness), you can make it darker by reducing the l value. Changing color: hsl(220, 15%, 55%) to color: hsl(220, 15%, 45%) makes the contrast ratio 5.2, which is acceptable.

  • On the image, remove width and replace margin with margin-bottom: 20px. Add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card: padding: 16px;.

  • Don't use complex selectors like main .card .content p, as it increases specificity, making it harder to override. It's best practice to give elements a class and then use that class as the selector.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  0