QR Code Component HTML5/CSS3

Community feedback

• 

  P

  Øystein Håberg•11,010

  @Islandstone89Posted 7 days ago

  Hi, well done!

  Here are some things that could be improved upon:

  HTML:

  • <main> holds all of the main content on a page. As a card would likely not be the only component on a page, I would wrap the card content in a <div class="card"> inside of <main>.

  • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Remove all the styles on html, it's not common for it to have any styles applied.

  • On the body, remove width: 100% - since the body is a block element, it takes up the full width by default.

  • Remove the width on the card. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Good job having max-width: 100% on the image! It's also common to give images display: block and height: auto.

  0
• 

  Muriel M.•560

  @MurielM87Posted 7 days ago

  Good job, your design is good, except the color of the text (should be light gray not black).

  0