QR- Code Component | HTML | CSS

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Andrea Ruiz,

  Congratulation on completing this challenge. your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • In my opinion, the alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor (not describes the image).
  • What was the purpose of using three separate tags? Instead of using three separate <p> tags, you can should use one <p> tag as the content does not make sense it was not read together then if you want to limit the width of the <p> tag, you may use max-width rule.
  • You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. You can read more in MDN
  • Adding rel="noopener" or rel="noreferrer" to target="_blank" links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Aside these, great job on this one. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Andrea Ruiz•130

  @AndreaDev14Posted about 2 years ago

  @PhoenixDev22 Thank you so much for your feedback. I wasn't aware of this issue and I'm very grateful that you brought it to my attention. Now, I'll be able to make the needed adjustments to my project 😉

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @AndreaDev14 Glad it was helpful. Happy coding!

  0
• 

  Mehdi•990

  @siavhnzPosted about 2 years ago

  Hello Andrea Ruiz, Congrats on the first challenge completion and starting this nice path to becoming a Frontendmentor challenger.

  You've done great work. If you want to get better results, consider using this excellent chrome extension

  Happy coding

  0

  ---

  

  Andrea Ruiz•130

  @AndreaDev14Posted about 2 years ago

  @siavhnz Thanks 😉

  1