Skip to content
Submitted about 2 years ago

QR code component - HTML, CSS

Alberto Mtz•20
@Eltunas170
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

More than doubts about this challenge, it is a thank you to the people who advised me in my first challenge.

Thank you for all the feedback and comments you can give me. :D

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Congrats @Eltunas170 on completing this challenge!

    Card looks good!

    To clean up your code and make it semantically correct you can implement the following code:

      <body>
        <article>
          <img src="" alt="" />
          <h1></h1>
          <p></p>
        </article>

        <div class="attribution"></div>
      </body>

    (The <article> element is used for cards)

    Congrats and happy coding!

    Marked as helpful
    0
  • Akram Adjab•380
    @akramAdjabPosted about 2 years ago

    -You could achieve the same result using fewer containers, try to remove all necessary tags -The text box title and paragraph there are not perfectly aligned vertically -You don't need a normalized CSS file because this is a very small project, and there is a lot of unnecessary code

    I hope my feedback is helpful!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord