QR Code Component [HTML + CSS]

Community feedback

• Account deleted

  Hey! Well done on your first project, you did great!

  I just read the code and it's pretty good! (way better than when I first started lol)

  Here are some tips I've compiled based on your code:

  • HTML: Everything is good here aside from some accessibility issues, they're pretty easy to fix though! just replace the h3 with a h1, and wrap everything inside the body with a <main>, as every page needs one h1 element and one main element

  • CSS: I don't see any issues here, good job!

  That's all, good job and keep up the good work!

  • Sydist

  1

  ---

  

  Sam Denishin•10

  @samdenishinPosted over 2 years ago

  @Sydist

  Hello Sydist, thank you for your comment!

  What do you think about the comments I left in the CSS? I wasn't really sure what certain functions did so I wrote my own interpretation after every line.

  Are those interpretations correct?

  Thanks!

  0
• 

  voqh•130

  @VoqhPosted over 2 years ago

  Hello @samdenishin congratulation on your first solution. Clean code. My opinion on your CSS comments; display:flex; Determines how elements will be displayed and not necessary to stretch elements full width. <Div> s will take up the width of the content inside if the width value is not set. justify-content:center, Aligns content to the center on the main-axis of the flex container. The main axis is determined by flex-direction value on the flex-container. align-items:center, Aligns items to the center on the cross-axis of the flex container. The cross-axis is determined by flex-direction value on the flex-container. This video helped me get a deeper understanding of flex-box.(https://www.youtube.com/watch?v=3YW65K6LcIA&list=RDCMUC29ju8bIPH5as8OGnQzwJyA&index=3)

  0