Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component (HTML + CSS)

Dom 10

@dj4815

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

First, let me say that I have just discovered that I never uploaded this solution. It's been 4 months since I made this and I don't quite remember but apparently I wrote the css completely by hand which is quite an accomplishment.

What challenges did you encounter, and how did you overcome them?

Again, I don't quite remember but it seems from the comments that I used colored borders to move stuff around, so that probably.

What specific areas of your project would you like help with?

A better technique for making and moving boxes around other than with colored borders would be nice. Other than that I think that it wasn't too difficult, even though now looking at it after 4 months of no html + css I wonder how i did it.

Thanks for your time!

Community feedback

haquanq ®️ 1,585

@haquanq

Posted

Hello Dom, nice work on the solution!

I'm not sure about what do you mean at "A better technique for making and moving boxes". Can you be more specific?

You should avoid using unnecessary div for wrapping elements (div has no semantic meaning). For example, img, h1, p don't need to be wrapped inside div, if you leave them be, the layout stay the same, even when you remove .card-text element, the layout stay the same!!

Also, consider using section or article to wrap the card instead of div. Depend on the type of content, you should decide when to choose which.

In short, keep you HTML clean and simple to improve semantic and maintainability!

Have a nice day and enjoy coding!!!

Marked as helpful

0

Dom 10

@dj4815

Posted

@haquanq Thank you so much for your detailed feedback!

Ok let me try to reword that; I have to make the boxes visible by adding a border so that I know where they are in space. The whole process just seems kind of cumbersome. I also don't quite understand flexbox or grid yet, maybe that's the problem.

I have read about section and article before, not sure why I didn't use them here.

Thanks again, I will improve everything you mentioned.

0
Dom 10

@dj4815

Posted

Now that I've uploaded the solution I can see that the line spacing is off. I'll try to fix that. I think I had some trouble with justify-content and the like.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord