QR Code Component (HTML and CSS)

Community feedback

• 

  Lucas Exequiel•200

  @arrejoriaPosted over 1 year ago

  Hey good job on this solution! 💯 I can leave you some tips

  I want to highlight some positive aspects of its design. These elements caught my attention and I think they are the strong point of your work:

  1. [HTML]: The HTML boxes infrastructure is good, you're on the right way.
  2. [CSS]: Variable CSS is a good practice to improve your speed on large layouts 👍

  Here are some recommendations that will help you improve your design:

  1. [Size Changes]: Note that you use an explicit width and height for some elements. That can be a problem for large layouts, try using max-width, max-height for example.
  2. [Positioning]: You are using relative and absolute to center the content of your container. Try using Flexbox or wrapping its left and top properties with a transform that might also work.

  keep it up you are doing great! 🧉

  Lucas,

  Marked as helpful

  1

  ---

  

  Tharun Raj•1,330

  @Code-BeakerPosted over 1 year ago

  @arrejoria Hello there! Thanks for your tips! I'm getting started with web development and I am constantly trying to improve myself. I really value your opinion about my project. Thank you!

  1
• 

  Vitor Shigueta•80

  @VitorShiguetaPosted over 1 year ago

  You can use body { height: 100vh; } to give a reference to your container and make it centered on the screen (it is appearing cut off the screen at the top)

  1

  ---

  

  Tharun Raj•1,330

  @Code-BeakerPosted over 1 year ago

  @VitorShigueta Hello! Thanks for the suggestion! I will use them in my next challenge to make it better!

  Happy Coding!

  0