@Dreamleaf
Posted
Pretty clean code for a beginner, well done!
Two things I can spot in your code that would improve things that may not be obvious.
For the QR image, be specific about what the image is doing... eg. "QR Code to frontendmentor.io" instead of just "QR Code". This will be more informative for users of screen readers and tell them exactly what will happen.
Secondly, you have used 100vh on the body class. This isn't wrong, but you may sometimes get unintended results on mobile viewports. Do a search and read about the alternative values of SVH and DVH - basically, just using VH includes UI elements such as the address bar - the alternative can ignore these and just focus on the DOM part of the view.
Great work though, I look forward to seeing you tackle more challenges.
Marked as helpful
@S02K
Posted
@Dreamleaf
Thank you for the helpful feedback i have now changed the ALT text i will also read up on SVH and DVH so i don't run into mobile issues later on!