QR Code Component - HTML & CSS

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Jhean Khendrick,

  Congratulation on finishing this challenge. I have few suggestions regarding your solution:

  CSS

  • Consider using min-height: 100vh instead of height: 100vh to the body , that let the body grows taller if the content of the page outgrows the visible page.

  • line-height: 1.5rem;Use a unitless line-height value to Avoid unexpected results. You can read more in mdn

  • Consider using rem for font size , it' not recommended to use px for font size as absolute units don’t scale for example 15px will always be 15px on the same device. Using pixels is a particularly bad practice for font sizing because it can create some accessibility problems for users with vision impairments.

  • To target the DOM elements for styling purposes, better to use classes so that it could be more manageable and reusable.

  • There are some repeated styles like : text-align: center;

  Aside these, great work! Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Jhean Khendrick•160

  @Galope-JheanPosted about 2 years ago

  @PhoenixDev22 Hi! I appreciate the suggestion, I went on and changed all of it as you suggested and I will use some of those for future projects now. Thank you!

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @JheanKhendrick Happy coding!

  1