Design comparison
SolutionDesign
Solution retrospective
First challenge , any feedback. thank you
Community feedback
- @davislocsPosted over 1 year ago
Hey whats up!
I have a few suggestions for you to improve your code:
-
Dont use
<div>
for everything. There are many other tags which you can use for better accessibility. For example use<main class="container">
instead of<div class="container">
and<section class="tittle">
instead<div class="tittle">
. Instead of<div class="attribution">
use<footer class="attribution">
. -
Its better to use
rem
units instead ofpx
.
Whatch this video about css units.
If you found this helpful please mark it as such :)
Happy coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord