QR code card using HTML and CSS basics

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  Alt text 📷:

  • The alt attribute should not contain underscores or hyphens, it must be human readable and understandable.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • To center the content horizontally, use justify-content: center; to the body. Also, you can remove the margin: 0 auto; in the .container selector.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  jadefurtado•80

  @jadefurtadoPosted almost 2 years ago

  @MelvinAguilar Thank you so much for the tips! I already put them into practice to improve my code. 😁

  0
• 

  Abraham•270

  @AbeeujahPosted almost 2 years ago

  Hi Jade, Nice solution you have up there..

  Here's a way you can improve it..

  HTML:

  Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  You can learn more about accesibility Here

  Always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>).

  Marked as helpful

  0

  ---

  

  jadefurtado•80

  @jadefurtadoPosted almost 2 years ago

  @Abeeujah Hello! 😁 The <main> tag is really important and I forgot to use it, so thanks for the tips!

  1