Skip to content
Submitted about 2 years ago

QR code component

Daniel Lasauskas•230
@mazinger086
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @mazinger086, congrats on completing this challenge!

    I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:

    Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • romila•3,570
    @romila2003Posted about 2 years ago

    Hi @mazinger086,

    Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great. There are some issues/suggestions I want to address:

    1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
    2. You should also wrap the footer within the footer tag e.g. <footer class="attribution"></footer>
    3. Rather than using margins to center the card, you can use the height property to allow the flex to work. e.g. min-height: 100vh;
    4. Since this challenge does not require making any responsive changes, you can remove the margins.

    Overall, great attempt and wish you the best for your future projects so keep coding 👍.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord