QR code component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Pangestu Nurcahyo Putro! 👋

  Nice work on this challenge! 🙌 Your solution is responsive and looks great! 👍

  You have gotten some wonderful feedback from @PhoenixDev22. I have some suggestions as well.

  • I recommend removing the media query. The card element has the same styling whether it's on desktop or mobile.
  • I suggest adding rel="noopener" to any anchor tags that have target="_blank". This is a security essential for external links. I recommend reading the web.dev article to learn more about this.

  I hope this helps! Keep up the good work! 👍

  P.S. I am also from Indonesia by the way. Salam kenal! 👋

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Pangestu Nurcahyo Putro,

  Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • It’s better the attribution lives in the <footer> landmark.

  • The alternate text should be not be hero img. And it should tells the users where it takes : like Qr code to frontend mentor

  • To center the component on the middle of the page you may use the flex/grid properties with min-height 100vh; to the body. Also you can add a little padding to the body to prevent the card from hitting the screen edges.

  Aside these , Good work! Hopefully this feedback helps

  1