Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <h4> with <h1> and wrap<div class="attribution"> in the footer tag to fix accessibility issue. for more on semantic html visit https://web.dev/learn/html/semantic-html/
There is no need to give greybox a margin value, a padding value. give .whitebox a width value of 100% and height value of 100vh
give the height, width, margin and padding a fixed value instead of a percentage value. For a responsive content, replace the width of .whitebox with max-width and change the height value to auto or give .whtebox a padding value for all the sides. e.g.:
.whitebox{ max-width: 320px; padding:16px;}
or.whitebox{ max-width: 320px; height: auto; padding: 16px;}
Give the img a max-width of 100% instead of a percentage width value.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@BeaulaEkkaPosted almost 2 years ago@Hassiai Thank you so much ! appreciate it.. this is really helpful.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord