Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

W3RKY 70

@xAnDrOm3dAx

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


The most difficult part of this challenge was to figure out which elements need styling and at which level. In terms of best practices, could someone link any resources for best practice in html and CSS?

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility
  • Example: <h1>Improve your front-end skills by building projects</h1>
  • If you have any questions or need further clarification, and feel free to reach out to me.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

W3RKY 70

@xAnDrOm3dAx

Posted

Hey thank you! Much appreciated. I am updating this now, also adding a landmark.

0

@Khawarmehfooz

Posted

Hey there, congratulations on completing this challenge! 🎉

To learn more about CSS and best practices for responsive web design, I recommend checking out FreeCodeCamp's curriculum on Responsive Web Design. It covers CSS and various other topics related to responsive design. You can find it here: FreeCodeCamp - Responsive Web Design

Happy coding! 💻

0

W3RKY 70

@xAnDrOm3dAx

Posted

Hello and thanks for the reply. I am working my way through The Odin Project, currently on the Javascript sections in Foundations. Do you know if this will this have similar content in terms of best practice?

0
Mukwende 1,370

@mukwende2000

Posted

@xAnDrOm3dAx yes the odin project is IMO the best free course as it doesn't spoon feed you but allows you to explore and research on your own, most of the links and resources they point you to are links that encourage best practices

0

@Khawarmehfooz

Posted

@xAnDrOm3dAx I haven't personally used The Odin Project, I can say that the curriculum of FreeCodeCamp is indeed great.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord