qrcode

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  wrap <div class="attribution"> in the footer tag to fix the accessibility issue.

  To center .qr-card on the page using flexbox, replace the height in the main with min-height:100vh.

  For a responsive content which wont require a media query for this challenge, give .qr-card a fixed max-width value. there is no need to give .qr-card a margin value.

  Give p and h1 a font-size of 15px. There is no need to give p a padding value for all the sides and h1 a padding bottom value. give p a margin-top value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  Ananda Putra Azril Al Kariko•230

  @putracode354Posted almost 2 years ago

  @Hassiai thank u , i hope you always give me a comment about my task , thank u

  0