Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

Sarah H. 55

@Arearda

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@OlaOluwalekan

Posted

Nice try!

However, you added to much padding into your qr-code-container class gene, there's little space for it to occupy. Also the border radius you added is somehow awkward. You could have used something like 10px for the qr-code-container and 5px for the image.

Also, you didn't stick strictly to the styles in the style-guide.md

Marked as helpful

1

Sarah H. 55

@Arearda

Posted

@OlaOluwalekan Thank you for the feedback!

0
Satyam Jha 400

@satyammjha

Posted

Great attempt @Arearda. I have some suggestions for you:-

  1. use the <br> tag after the word front-end so that other skills will move to the next line.
  2. use the <br> tag after the word frontend and to in the paragraph.
  3. Use color: rgb(135, 135, 135); for the paragraph.
  4. Your design is not responsive. Use media queries to make it responsive according to the screen resolutions.
  5. For fonts and colors used in the projects please read the style guide of the project before coding.

Hope these tips will help you. Happy Coding 🤗✌🏻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord