Melvin Aguilar ๐ง๐ปโ๐ปโข 61,220
@MelvinAguilar
Posted
Hi๐. Good job on completing the challenge !. I have some feedback for you if you want to improve your code.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding! ๐
Marked as helpful
0
Linda Bโข 270
@Lynd7
Posted
@MelvinAguilar Hi ! Thank you very much for your comment, it's very helpful and I will make some changes on my code.. ๐
1