My QR Code Component Solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi👋. Good job on completing the challenge !. I have some feedback for you if you want to improve your code.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding! 🎄

  Marked as helpful

  0

  ---

  

  Linda B•270

  @lindabgaaPosted almost 2 years ago

  @MelvinAguilar Hi ! Thank you very much for your comment, it's very helpful and I will make some changes on my code.. 😁

  1