QR-Code-component using HTML and CSS

Community feedback

• 

  P

  Godwin•410

  @itadori-kunPosted almost 2 years ago

  Hello Pri89yanka,

  Congratulations on completing the challenge, here are a few suggestions.

  • Stick with one type of unit call ie choose either px or rem and not both.
  • body{width: 100%; background-color: hsl(212, 45%, 89%); display: grid; min-height: 100vh; row-gap: .5rem; font-family: "Outfit", sans-serif; place-content: center;}

  This keeps your code right at the center, the other code was being pushed down the viewport because of the padding you used with the rem unit.

  Also, check this link web.dev to know the reasons why specific units are used.

  hope it helps, once again Happy coding 👻

  Marked as helpful

  1

  ---

  

  Pri89yanka•20

  @Pri89yankaPosted almost 2 years ago

  @itadori-kun Thanks for suggestions.

  0