QR code component for Desktop and Mobile using Flexbox

Community feedback

• 

  P

  Dilhan Boca•220

  @dboca93Posted 11 months ago

  Hey @lisagriggs, well done on submitting this task. I hope you're enjoying your coding experience. This is a decent first attempt. One thing to focus on might be learning about semantic html elements like main, section and article. For example, instead of:

  .container {
      height: 95vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  This could be:

   main {
      max-width: 100vw;
      min-height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  This small adjustment would be great. Hope you appreciated my input, all the best !

  Marked as helpful

  1

  ---

  

  Lisa•10

  @lisagriggsPosted 11 months ago

  Thank you @dboca93. I will review semantic html elements again. I am so used to using and seeing div’s within my work environment that I use it unconsciously. Also the max-width and min-height properties I will remember too. I really appreciate the help. Thank you ☺️

  0