Design comparison
Solution retrospective
Is the html and css code I have used best practice? Are therevshortcuts I can utilise better? Have I structured my html correctly?
Community feedback
- @dboca93Posted 11 months ago
Hey @lisagriggs, well done on submitting this task. I hope you're enjoying your coding experience. This is a decent first attempt. One thing to focus on might be learning about semantic html elements like main, section and article. For example, instead of:
.container { height: 95vh; display: flex; flex-direction: column; justify-content: center; align-items: center; }
This could be:
main { max-width: 100vw; min-height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; }
This small adjustment would be great. Hope you appreciated my input, all the best !
Marked as helpful1@lisagriggsPosted 10 months agoThank you @dboca93. I will review semantic html elements again. I am so used to using and seeing div’s within my work environment that I use it unconsciously. Also the max-width and min-height properties I will remember too. I really appreciate the help. Thank you ☺️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord