Design comparison
Community feedback
- @emjayrukaPosted 9 months ago
Hey Abhishek, nice work! I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.container> could be replaced with a <main> tag while the <div.attribute> could be replaced with a <footer> tag.
I also noticed an issue with image linking, as your image doesn't seem to load correctly. Ensure that you are using the correct file paths or URLs.
I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.
I hope I was of help.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord