@Liyyy9
Posted
Great job completing this challenge! I have a few suggestions for improvement based on feedback I received for the same project. I think they could be useful for you as well.
HTML:
-
Add a
<main>
element to wrap all of your content except the<header>
and<footer>
. This improves accessibility and acts as a landmark for your webpage. Make sure to include your card within the<main>
element. -
Consider changing your
<p class="para1">
tag to an<h2>
tag. Typically, a page should only have one<h1>
tag for the main heading. Since this challenge doesn’t include a main heading, it would be appropriate to use an<h2>
tag instead.
CSS:
-
Don’t forget to include a fallback font in your
font-family
property. It should be specified like this:font-family: 'Outfit', sans-serif;
. -
Avoid using
px
forfont-size
. Instead, userem
units to ensure the font size scales with the user’s default browser settings, which enhances accessibility. -
Since you want all text to be centered, you only need to apply
text-align: center
to the<body>
element. The child elements will inherit this property, so you can remove any redundanttext-align: center
declarations from elsewhere.
Hope this helps!
Marked as helpful
@aniketinTech
Posted
@Liyyy9 Thank you so much for your feedback. I'll consider your suggestions and that's helpful. Thank you so much for your time.