QR Code Component Flexbox CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Juan, great job!

  Try to remove all margin from card class and use flexbox to the body for center the card. Read here -> flex guide

  Also set heigth of body to 100vh because Flexbox aligns to the size of the parent container.

  Hope this help and happy coding :)

  Marked as helpful

  1

  ---

  

  Juan Gomez•260

  @newbpydevPosted almost 3 years ago

  @denielden Hey Daniel, thanks for the tip, I will play around more with flexbox to get it down right. Thanks for the height tip too, I think I used it at first but then I ran into a bug, I will definitely use it next time. 🙇🏾‍♂️

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @newbpydev You're welcome. And don't forget to mark my comment as helpful if it helped ;)

  happy coding

  Marked as helpful

  0

  

  Juan Gomez•260

  @newbpydevPosted almost 3 years ago

  @denielden Thanks, I got the 100vh bug again, the problem you need to test it by zooming on the page and then scrolling down and you will see what will happen.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @newbpydev Have you removed all the margin from content and attribution class?

  Otherwise try using min-height on the body

  Marked as helpful

  1

  

  Juan Gomez•260

  @newbpydevPosted almost 3 years ago

  @denielden Yes, I have now used the min-height to solve the bug I had, I believe I had a margin of 0 and then I added to the attribution and content.

  1

  

  Juan Gomez•260

  @newbpydevPosted almost 3 years ago

  @denielden My mistake, I did on the newer projects, but this one I didn't add the min-height property.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @newbpydev perfect so now you solved?

  0