QR code component Flexbox

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi , congratulations on your solution!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  2.Add the box shadow to stylize the card: box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

  3.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, and making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @py-rod, some suggestions to improve you code:

  • Remove the Picture Element it's not needed for this challenge, since you only have one image.

  • Remove the following from .card__content__img > img"; it's not being used at all.

  .card__content__img > img {
      object-fit: contain;
      margin: auto;
  }
  

  • Card Class width needs to be max-width to make card responsive.

  • Remove the Media Query if done properly, the card itself should responsive enough.

  Happy Coding!

  1

  ---

  

  p-rod•190

  @py-rodPosted about 2 years ago

  @vcarames Thanks for commenting. I've already made the corrections :)

  0