QR Code

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/ Give .container a fixed width instead of percentage width , you can give it a fixed width of 300px or 400px.

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; min-height:100vh; display: grid place-items: center to the body. instead of giving .container a margin value.

  give .container-text a padding value for all the sides instead of the width:85%.

  Hope am helpful. Happy coding

  Marked as helpful

  0
• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY OLUWASINA!

  Congratulation on completing your first challenge

  I noticed a few things I would like to point out:

  • You will need to reduce the size of your parent container as it is too large.

  • You have some accessibility issues, I can help you with some of them:

    • Instead of using a div for <div class="container">, you should instead opt for a more semantic element like main

    • The same goes for <div class="attribution"> instead of a div a footer would be much better.

    • you can learn more about sematic element here

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  Marked as helpful

  0