Skip to content
Submitted about 2 years ago

QR CODE COMPONENT.

Jeffery Evbodi•110
@maro-og
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

All feedbacks are welcome, Thank you in advance.

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @maro-og, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    The HTML structure is fine and works, and you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Jeffery Evbodi•110
    @maro-ogPosted about 2 years ago

    @correlucas Thanks so much for the tips, I appreciate.🙏

    0
  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @maro-og, some suggestions to improve you code:

    • Currently, your HTML Code lacks structure and some of the element are being used incorrectly.To better structure your content and make it a lot clearer, you want to implement Semantic HTML.

    Why use Semantic HTML?

    1. Accessibility: Semantic HTML makes webpages accessible for mobile devices and for people with disabilities as well. This is because screen readers and browsers are able to interpret the code better.
    2. SEO: It improves the website SEO, or Search Engine Optimization, which is the process of increasing the number of people that visit your webpage. With better SEO, search engines are better able to identify the content of your website and weight the most important content appropriately.
    3. Easy to Understand: Semantic HTML also makes the website’s source code easier to read for other web developers.

    More Info

    https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure

    https://www.freecodecamp.org/news/semantic-html5-elements/

    https://dev.to/poulamic/writing-semantic-html-3436

    • Theres no need for a media query for the challenge.

    • You CSS Reset is extremely small, you want to add more to it. Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

    https://www.joshwcomeau.com/css/custom-css-reset/

    https://meyerweb.com/eric/tools/css/reset/

    http://html5doctor.com/html-5-reset-stylesheet/

    Happy Coding!

    Marked as helpful
    0
    Jeffery Evbodi•110
    @maro-ogPosted about 2 years ago

    @vcarames Thanks for the feedback, I'll definitely look them up and make corrections where necessary.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord