QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @NikoFilou 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • You could use a CSS Reset to remove browser built-in styles and reduce browser inconsistencies. Your body's default margin causes the vertical scrollbar to appear.

  Popular reset style sheets:

  • A modern alternative to CSS resets
  • CSS Tools: Reset CSS
  • Custom CSS Reset

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="card">.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • Use max-width: 300px to .card selector instead of width, this will make the container card a bit responsive on mobile and set the element's maximum width to 300px.

  • Use margin: 0.938rem or margin: 15px in the .card selector to add some space for the container card and the screen edge on mobile devices.

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  1