Design comparison
SolutionDesign
Solution retrospective
Thanks :)
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered correctly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states, Just add the following style rule
body { display: grid; place-items: center; min-height: 100vh }
- Now remove these styles, after removing you can able to see the changes
.container { margin: 10% auto; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
- You'd better use flexbox for this solution to center the card correctly.
- You can add flexbox and
min-height: 100vh
to thebody
body { /* background-color: var(--Grayish-blue); */ background-color: hsl(212, 45%, 89%); /* the recommended color for the background */ display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100vh; }
- after adding it, you don't need to use
margin
in the.container
to center the card:
.container { max-width: 300px; /* max-width makes it responsive */ /* margin: 10% auto; */ }
Hope I am helpful. :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord