Skip to content
Submitted almost 2 years ago

QR component using CSS custom properties

AndreeaKiara•40
@AndreeaKiara
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please tell me how I can improve :)

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Replace <article class="qr"> with the main tag, and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

    To center .qr on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

    There is no need to style .qr-image area and .qr-img. give .qr-img a max-width of 100% and border-radius.

    Give .qr-text a padding value for all the sides and give .qr-tittle a margin-bottom value of .qr-description a margin-top value for the space between the text. There is no need for a font-size in .qr-tittle

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    1
    AndreeaKiara•40
    @AndreeaKiaraPosted almost 2 years ago

    @Hassiai Thank you for the helpful feedback! I have one question regarding the last part, how can I get a font-size match on the title if I don't set it in the .qr-title? If I let it be as the standard h1 it is too big compared to the design file (as seen in the screenshot comparison)

    Thank you!

    0
  • バレンタイン 😈•64,170
    @VCaramesPosted almost 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    Congrats on completing your first challenge!🎊🎆

    • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
    • The alt tag description for the “QR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

    If you have any questions or need further clarification, feel free to reach out to me.

    Happy Coding!🎄🎁

    Marked as helpful
    1
  • Sinisa Vukmirovic•1,690
    @SinisaVukmirovicPosted almost 2 years ago

    Hello!

    To improve, start with fixing errors from your report.

    This "Document should have one main landmark" means you are missing <main> semantic element in your html. Landmark just means element.

    This "All page content should be contained by landmarks" means all non-semantic elements should be inside of semantic elements, and not directly inside of <body> element.

    More about semantic elements

    Hope this helps! Good luck!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord