Submitted over 1 year ago

QR Code Component

Radek Tomasek•160

@radektomasek

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello 👋,

At this time, I am submitting a straightforward solution written in vanilla HTML/CSS. There was no particular blocker and I utilized the implementation as a good way how to dig deeper into some properties of Flexbox.

Just a fun fact, I learned the gap one could be used as a Flexbox property. I haven't used it at the end, however, until today, I had thought the gap is mostly used for the Grid.

Have a wonderful day.

Community feedback

Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS 📐:

The width: 100vw property for main element is not necessary. because it's a block level element which will take the full width of the page by default.

Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord