Design comparison
Solution retrospective
Suggestions regarding better coding practices, or improvements in this code is appreciated.
Community feedback
- @anoshaahmedPosted almost 3 years ago
hey good job on this challenge! your report above shows a few issues though:
- wrap everything in your body in
<main>
OR use semantic tags! if you're usingdiv
right afterbody
, then give them arole=""
; however, it's a little frowned upon to userole
right after body, so try to stick with semantic tags instead. you can read more about landmarks here - you should have at least one
<h1>
in your webpage
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful0 - wrap everything in your body in
- @NaveenGumastePosted almost 3 years ago
Hay ! Good Job you made it look nearly perfect to the preview
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body like it should be your container
-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc
-> But use header tag only once in main heading element.
Keep up the good work!
Marked as helpful0@Sarang-PatelPosted almost 3 years ago@Crazimonk Thanks for your suggestions.
Just a question, why does my solution in design comparison different than one seen on preview site?
0@NaveenGumastePosted almost 3 years ago@Sarang-Patel in preview also it is not as the design
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord