Design comparison
Solution retrospective
I'm happy with the result since it's the first repository I've made.
What challenges did you encounter, and how did you overcome them?After I've finished the image didnยดt show up, so I had to make some changes.
What specific areas of your project would you like help with?The responsive design.
Community feedback
- @Grego14Posted 6 months ago
๐ Hello! ๐ Congratulations on completing the challenge! ๐
Remember not to use the alt attribute when the image has no semantic meaning or is only for decoration. And when you use it, you should write a more descriptive text.
And if you decide not to use an alt attribute, remember to remove the image from the accessibility tree, the
aria-hidden
attribute will help you with that.Do not use the br tag to break texts, as it is considered a bad practice and can lead to accessibility problems, read more here ๐ br.
I don't recommend using a fixed width in elements like the body, unless you want to make some kind of website where all the content has a few spaces on the sides, but for something like that it's better to use padding.
I recommend that you use min-height instead of height as that will allow your content to grow if necessary.
I hope this helps! ๐
Marked as helpful0@Ghm84Posted 6 months ago@Grego14 Hey Grego, of course it helps. Thank you so much for your feedback and the suggestion!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord