Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

Aaryn 130

@Aaryn-Robinson

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feel free to leave feedback on different implementations or ways to improve my code! Thank you!

Community feedback

@bccpadge

Posted

Hello there 👋🏼

I have a couple recommendations to improve your solution.

HTML

  • To make your website more accessible make sure you use a <main> tag instead of a <div> tag

  • Also I see you are using incorrect heading tag like a <h4>. Make sure you use heading tags in chronological order like a h1 through h6.

CSS

  • Be sure to check the styleguide.md file to get the correct colors to look like the design

  • To center your card component you can add

body{
min-height: 100vh;
}

you can remove the code below

body{
height: 100vh;
}

Hope this helps you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord