Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code component css html

Iván Garcia• 90

@info1922

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Axseinga• 430

@axseinga

Posted

Hi Ivan! Congrats on finishing this challenge!

I've checked your accessibility issues and if you want to fix them you could use "main" tag for your <div class="container"> and 'footer' for your <div class="attribution">. This is a small component that would be a part of the bigger project however it is good to start using more HTML semantic tags from the beginning :) Don't forget to link up your solution to your profile on GitHub or LinkedIn ( Coded by <a href="#"> Ivan Garcia</a>)! You can use media queries for the mobile version. At the moment your component is centered vertically if open on mobile (has a huge top margin), that is because of the property justify-content: center on your container element. You can test it in your devtools or website like Responsinator. A big plus for using flexbox from the start :)

Happy coding!

Marked as helpful

1

Iván Garcia• 90

@info1922

Posted

@axseinga Thank you very much for the observations, I will carry out the recommended modifications :)

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord