@axseinga
Posted
Hi Ivan! Congrats on finishing this challenge!
I've checked your accessibility issues and if you want to fix them you could use "main" tag for your <div class="container">
and 'footer' for your <div class="attribution">
. This is a small component that would be a part of the bigger project however it is good to start using more HTML semantic tags from the beginning :) Don't forget to link up your solution to your profile on GitHub or LinkedIn ( Coded by <a href="#"> Ivan Garcia</a>
)! You can use media queries for the mobile version. At the moment your component is centered vertically if open on mobile (has a huge top margin), that is because of the property justify-content: center
on your container element. You can test it in your devtools or website like Responsinator. A big plus for using flexbox from the start :)
Happy coding!
Marked as helpful
@info1922
Posted
@axseinga Thank you very much for the observations, I will carry out the recommended modifications :)
Happy coding!