Design comparison
Solution retrospective
I feel like the QR code has lost in quality compared to the given designs, if you have any suggestions for it ? Happy to hear it/them :)
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Aatypic, Congratulations on completing this challenge!
❓ Answering your question:
I've opened your solution in a 27'' screen and the image is perfect, I don't think this will lose the quality since its a svg image, so I can ensure you thats fine.
Something I've noticed in your code is that in many occasions you've added some
<div>to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be<div>or<main>if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>✌️ I hope this helps you and happy coding!
Marked as helpful1@AatypicPosted about 2 years ago@correlucas Thank you for your answer. Did anybody say div ? :D But yes this was not necessary.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord