QR Code Component - CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  CSS 🎨:

  • Looks like you already centered the component horizontally but the issue is the component is not centered vertically, So just fix it by adding this single css rule

  body {
     justify-content: center;
  }
  

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  cisneConCorbata•170

  @cisneConCorbataPosted over 1 year ago

  Hi there! You did amazing, in fact, I actually learned something while looking at your code, you're going to save me so much time in the future, I didn't know you could establish variables! (I'll credit you in my next project, of course).

  Accessibility

  Landmarks are very important for people who use screen readers, so get used to applying them. They are your basic built in tags that specify the content within them , like <main>, <footer>, <header>, etc. All HTML must be contained by landmarks

  I use <main> to encase the focus of the website (in this case, the QR code), and footer for the attribution:

  <footer>
  <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
      Coded by <a href="https://github.com/AlvaNeedsFood">Alvaro Alvarez P</a>.
    </div>
  </footer>
  

  Centering vertically

  Whenever I have issues with flexbox I use grid, it's very easy to understand. In this case, you just need to use:

  display: grid;
  place-items: center;
  height:100vh;
  

  Hope this helps!

  Marked as helpful

  0

  ---

  

  AlvaNeedsFood•20

  @AlvaDevsPosted over 1 year ago

  Hi @cisneConCorbata 👋

  Thank you very much for taking the time to look at my code and giving me feedback. ✨

  • I really appreciate the advice on landmarks! It will really help me to improve the code of my next projects and challenges. 🖇

  • About centering vertically, is visibly better the performance that I could reach if I use a little more grid in cases like this... 🧐 I think I should start thinking outside the flexbox a little bit sometimes.

  • And well, it only remains for me to say that it makes me feel very flattered and happy to have been of some help, believe me 🎖, setting even a couple of variables for some colors, fonts, etc, can help a lot in improving performance!

  It's an honor to appear in your next project, and know that you'll be in mine too! Again, thanks for your advice Sr. @cisneConCorbata 🦢👔

  0