HTML-5, CSS

Community feedback

• 

  Zeyad Mohamed•320

  @ZeyadMohamed1805Posted almost 2 years ago

  For a first project, this is fabulous work! 🔝🔝 I do have some suggestions for you: 🤔

  1. Try setting the border-radius of the QR Box & the image as the same value (for example 20px) would be more consistently looking . Using pixels for border-radius is common practice! 😎
  2. Setting the image's weight and height with different values will make it look a bit uneven! try just setting the width to 100% and not setting the height to a specific value. If you follow that by removing the margins of the image, it should take the size of the QR Box! 👌
  3. To set some space between the image and the QR Box, simple add a padding (for example 1rem) to the QR Box. 😎

  I hope you would find these improvements helpful! 🎇 Keep up the awesome work! 🔝🔝

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="qr-box">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS click here

  To center .qr-box to the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Give .img a max-width of 100% instead a width and height value. For a responsive content replace the width of .qr-box with max-width, there is no need for a height value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1