QR code component challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution includes incorrect semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <section class="component"> element with the proper semantic element <main> along with <section class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Carolina Kazmer•40

  @CarolinaKzPosted over 1 year ago

  @0xAbdulKhalid Thank you very much for your detailed feedback! I will correct that :D

  0
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

  .container {
    display: absolute;
    top:50%;
    left: 50%;
    transform: translate(-50%, -50%);
  }
  

  the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

  Marked as helpful

  0

  ---

  

  Carolina Kazmer•40

  @CarolinaKzPosted over 1 year ago

  Thank you! :) @Bader-Idris

  1
• 

  Oxgood•60

  @OxgoodPosted over 1 year ago

  just set the body's height to 100vh and certer it by using flexbox property, align-item:center; and justify content:center; Without specifying the height, it won't be centered.

  0

  ---

  

  Carolina Kazmer•40

  @CarolinaKzPosted over 1 year ago

  @Oxgood Thank you!!

  0
• 

  ellencaroliny•120

  @ellencarolinyPosted over 1 year ago

  You did very great! I have some difficult too about the sizes, but maybe if you check the style-guide you will find the sizes for height and weight, keep the good job! Congrats.

  0

  ---

  

  Carolina Kazmer•40

  @CarolinaKzPosted over 1 year ago

  @ellencaroliny Thank you very much! I'm going to check it :)

  0